From: Nathan Bossart <nathandbossart@gmail.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: zhjwpku@gmail.com
Cc: xu.xw2008@163.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17903: There is a bug in the KeepLogSeg()
Date: Thu, 27 Apr 2023 14:47:46 -0700
Message-ID: <20230427214746.GA1986346@nathanxps13> (raw)
In-Reply-To: <20230425.131452.517547289278432754.horikyota.ntt@gmail.com>
References: <20230421.104231.1594652765237022266.horikyota.ntt@gmail.com>
<20230421214347.GA1441786@nathanxps13>
<20230424191452.GA1698829@nathanxps13>
<20230425.131452.517547289278432754.horikyota.ntt@gmail.com>
On Tue, Apr 25, 2023 at 01:14:52PM +0900, Kyotaro Horiguchi wrote:
> At Mon, 24 Apr 2023 12:14:52 -0700, Nathan Bossart <nathandbossart@gmail.com> wrote in
>> When determining the oldest segment that must be kept for
>> replication slots, KeepLogSeg() might calculate a segment number
>> ahead of the one for the LSN given to the function. This causes
>
> Maybe the KeepLogSeg() is a mistake of
> XLogGetReplicationSlotMinimumLSN()?
I adjusted the commit message to call out that function explicitly. Also,
I decided to go with the "keep < recptr" approach since there's no reason
to do anything in that block otherwise.
Thanks!
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: nathandbossart@gmail.com, horikyota.ntt@gmail.com, zhjwpku@gmail.com, xu.xw2008@163.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17903: There is a bug in the KeepLogSeg()
In-Reply-To: <20230427214746.GA1986346@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox