pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Dmitry Dolgov <9erthalion6@gmail.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: artem.anisimov.255@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17949: Adding an index introduces serialisation anomalies.
Date: Wed, 21 Jun 2023 10:58:12 +0200
Message-ID: <20230621085812.idputjd7w3ejjih3@ddolgov.remote.csb> (raw)
In-Reply-To: <CA+hUKGJP3g6PF4vES0X0zy34uuSvHxHUhoq65A_WtzqxPpJ_6g@mail.gmail.com>
References: <17949-a0f17035294a55e2@postgresql.org>
	<CA+hUKGLgtMZbzm5md-eKtoKQo7tZU+FVM95YPTfH9k+3UQcvSQ@mail.gmail.com>
	<20230615072928.u3eypnf3evdikdas@ddolgov.remote.csb>
	<CA+hUKGLE3SONfzBbj3q7T7qYx5FQ9Pk_iGx6N7nYim1qgRrvUg@mail.gmail.com>
	<CA+hUKGKuETgQ5a+uS2grX+muz5zEqCD36vM0xDt_C+Utx761nw@mail.gmail.com>
	<CA+hUKG+zAbVgU91ZjkaCd=1AFOaMRbOp0=E9DP0BwippqqGx5g@mail.gmail.com>
	<CA+hUKG+3B7uBkJd4rr2FXhTc+95F3RvRovbhBM2UDt68aL5a-g@mail.gmail.com>
	<CA+hUKGJATT51T0Vkg0FDkQa5boQv-WoqL1_KM=313ySu0MVqig@mail.gmail.com>
	<20230619121757.gjvuvypp25ngwkux@ddolgov.remote.csb>
	<CA+hUKGJP3g6PF4vES0X0zy34uuSvHxHUhoq65A_WtzqxPpJ_6g@mail.gmail.com>

> On Tue, Jun 20, 2023 at 01:22:19PM +1200, Thomas Munro wrote:
> On Tue, Jun 20, 2023 at 12:18 AM Dmitry Dolgov <9erthalion6@gmail.com> wrote:
> > > On Mon, Jun 19, 2023 at 09:30:12PM +1200, Thomas Munro wrote:
> > > +#if 0
> > >         /*
> > >          * Ignore any claimed entries past what we think is the end of the
> > >          * relation. It may have been extended after the start of our scan (we
> > >          * only hold an AccessShareLock, and it could be inserts from this
> > >          * backend).
> > >          */
> > >         if (block >= hscan->rs_nblocks)
> > >                 return false;
> > > +#endif
> >
> > Great, thanks! Can confirm, after applying both the posted patch and the
> > change above the issue is not reproducible anymore.
>
> Here's a cleaned-up version of the first two changes.  What do you
> think about the assertions I make in the commit message for 0002?

Yep, it sounds correct to me. After a quick look I couldn't find where
exactly the similar code lives in the pre-tableam version, so can't say
anything about back-patching there.





view thread (28+ messages)  latest in thread

Message-ID: <20230621085812.idputjd7w3ejjih3@ddolgov.remote.csb>
Permalink:  ../20230621085812.idputjd7w3ejjih3@ddolgov.remote.csb/
Also on:    postgresql.org/message-id/20230621085812.idputjd7w3ejjih3@ddolgov.remote.csb

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: 9erthalion6@gmail.com, thomas.munro@gmail.com, artem.anisimov.255@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17949: Adding an index introduces serialisation anomalies.
  In-Reply-To: <20230621085812.idputjd7w3ejjih3@ddolgov.remote.csb>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox