From: Nathan Bossart <nathandbossart@gmail.com>
To: Gurjeet Singh <gurjeet@singh.im>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: richard.vesely@softea.sk
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18016: REINDEX TABLE failure
Date: Wed, 26 Jul 2023 13:16:51 -0700
Message-ID: <20230726201651.GC3310393@nathanxps13> (raw)
In-Reply-To: <20230726175000.GA3259285@nathanxps13>
References: <18016-2bd9b549b1fe49b3@postgresql.org>
<ZKirERBzkM48E0op@paquier.xyz>
<1457241.1688775601@sss.pgh.pa.us>
<CABwTF4XCTA=guV=4v3xkQnKhtqKsW2njeKeZCNtDhSFoYRWfDQ@mail.gmail.com>
<ZKpn+44jciv6Ym3/@paquier.xyz>
<1867443.1688912310@sss.pgh.pa.us>
<CABwTF4WX=m5pQvKXvLFJoEH=hSd6O=iZSqxVqHKjFm+iL-AO=w@mail.gmail.com>
<20230726175000.GA3259285@nathanxps13>
On Mon, Jul 10, 2023 at 09:35:05AM -0700, Gurjeet Singh wrote:
> The code block movement involved slightly more thought and care than I
> had previously imagined. As explained in comments in the patch, the
> enumeration and suppression of indexes on the main table must happen
> before any CommandCounterIncrement() call, hence the
> reindex-the-toast-table-if-any code had to be placed after that
> enumeration.
Do we need to add another CCI after reindexing the TOAST table? It looks
like we presently do so between reindexing each relation, including the
TOAST table.
+ * This should be done after the suppression of the use of indexes (above),
+ * because the recursive call to reindex_relation() below will invoke
+ * CommandCounterIncrement(), which may prevent enumeration of the indexes
+ * on the table.
I'm not following this. We've already obtained the list of index OIDs
before this point. Does this create problems when we try to open and lock
the relations? And if so, how?
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: nathandbossart@gmail.com, gurjeet@singh.im, tgl@sss.pgh.pa.us, michael@paquier.xyz, richard.vesely@softea.sk, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18016: REINDEX TABLE failure
In-Reply-To: <20230726201651.GC3310393@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox