From: Nathan Bossart <nathandbossart@gmail.com>
To: hubert depesz lubaczewski <depesz@depesz.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: Robert Haas <rhaas@postgresql.org>
Subject: Re: Wrong datatype in docs for wal_summary_keep_time
Date: Mon, 8 Jan 2024 21:47:22 -0600
Message-ID: <20240109034722.GA3031061@nathanxps13> (raw)
In-Reply-To: <20240108232311.GA3017966@nathanxps13>
References: <ZZwkujFihO2uqKwp@depesz.com>
<20240108232311.GA3017966@nathanxps13>
On Mon, Jan 08, 2024 at 05:23:11PM -0600, Nathan Bossart wrote:
> On Mon, Jan 08, 2024 at 05:37:14PM +0100, hubert depesz lubaczewski wrote:
>> I was reviewing new changes, and found out that we now have
>> "wal_summary_keep_time" setting, but the docs
>> (https://www.postgresql.org/docs/devel/runtime-config-wal.html#RUNTIME-CONFIG-WAL-SUMMARIZATION)
>> say that it's boolean, while it is integer.
>
> Indeed. I'll try to get this committed tonight unless Robert beats me to
> it.
I noticed that the docs also fail to mention how the value of this
parameter is interpreted when specified without units, so I've put together
a v2 patch that fixes this, too.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.comAttachments:
v2-0001-Fix-documentation-for-wal_summary_keep_time.patch (text/x-diff, 0B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: nathandbossart@gmail.com, depesz@depesz.com, pgsql-bugs@lists.postgresql.org, rhaas@postgresql.org
Subject: Re: Wrong datatype in docs for wal_summary_keep_time
In-Reply-To: <20240109034722.GA3031061@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox