From: Noah Misch <noah@leadboat.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Christophe Pettus <xof@thebuild.com>
Cc: vaibhave postgres <postgresvaibhave@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-bugs@lists.postgresql.org
Cc: vsekar@microsoft.com
Subject: Re: vacuumdb: permission denied for schema "pg_temp_7"
Date: Mon, 7 Oct 2024 12:40:54 -0700
Message-ID: <20241007194054.5d@rfd.leadboat.com> (raw)
In-Reply-To: <ZwQJYcuPPUsF0reU@nathan>
References: <2603142.1726873660@sss.pgh.pa.us>
<5f37ee56-14fb-44fe-9150-9eb97e10538b@oss.nttdata.com>
<2649165.1726898595@sss.pgh.pa.us>
<CAM_eQjyWnu_LUt6JWjh3boNFHAT9DBrcbamhG3Xy39Q4Ph=2rg@mail.gmail.com>
<ZvGye19tHrhLCpFl@nathan>
<E9660D68-5B26-488E-9AB2-2CA1E8EDDDA1@thebuild.com>
<ZvIRG6282T33q3Ku@paquier.xyz>
<00d98a9f-bec1-4cd0-b59e-1043ae04c8bc@oss.nttdata.com>
<ZvNG2H9GzpQ7YrFQ@paquier.xyz>
<ZwQJYcuPPUsF0reU@nathan>
On Mon, Oct 07, 2024 at 11:16:33AM -0500, Nathan Bossart wrote:
> Regarding commit 1ab67c9...
>
> On Wed, Sep 25, 2024 at 08:10:16AM +0900, Michael Paquier wrote:
> > Thanks. As I am kind of behind this one, I'll go fix it first. Let's
> > sort out the permission bits after that one is sorted out. REL_17_0
> > is out, so this can happen across all branches.
>
> For consistency with the surrounding code, I think we should schema-qualify
> the operator and add a newline after "WHERE relpersistence != 't'". If
> folks agree, I can handle committing the attached patch.
Not just code consistency. A code comment requires the schema qualification:
* Since we execute the constructed query with the default search_path
* (which could be unsafe), everything in this query MUST be fully
* qualified.
> --- a/src/bin/scripts/vacuumdb.c
> +++ b/src/bin/scripts/vacuumdb.c
> @@ -684,7 +684,8 @@ vacuum_one_database(ConnParams *cparams,
> * Exclude temporary tables, beginning the WHERE clause.
> */
> appendPQExpBufferStr(&catalog_query,
> - " WHERE c.relpersistence != " CppAsString2(RELPERSISTENCE_TEMP));
> + " WHERE c.relpersistence OPERATOR(pg_catalog.!=) "
> + CppAsString2(RELPERSISTENCE_TEMP) "\n");
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: noah@leadboat.com, nathandbossart@gmail.com, michael@paquier.xyz, masao.fujii@oss.nttdata.com, xof@thebuild.com, postgresvaibhave@gmail.com, tgl@sss.pgh.pa.us, pgsql-bugs@lists.postgresql.org, vsekar@microsoft.com
Subject: Re: vacuumdb: permission denied for schema "pg_temp_7"
In-Reply-To: <20241007194054.5d@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox