agora inbox for pgsql-bugs@postgresql.org  

help / color / mirror / Atom feed

From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Alexander Kukushkin <cyberdemn@gmail.com>
Cc: Sutou Kouhei <kou@clear-code.com>
Cc: smithpb2250@gmail.com
Cc: torikoshia@oss.nttdata.com
Cc: horikyota.ntt@gmail.com
Cc: michael@paquier.xyz
Cc: pgsql-hackers@postgresql.org
Cc: bungina@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_rewind WAL segments deletion pitfall
Date: Tue, 12 Nov 2024 20:18:30 +0100
Message-ID: <202411121918.beiyanf6gfnb@alvherre.pgsql> (raw)
In-Reply-To: <CAFh8B==NeH=4c-3Fz3uvra-WyTQYY7QkH95m-vZNPOw2YK_KjQ@mail.gmail.com>

Hello

After reading the whole thread a couple of times to make sure I
understood the problem correctly, I think the approach in the v10 patch
is a reasonable one.  I agree that it's better for maintainability to
keep a separate hash table.  I made some cosmetic adjustments -- didn't
find any fault in the code.  I also verified that the test is hitting
the problematic case.

So here's v11, which I'll try to get out tomorrow.

I also assessed back-patching this.  There's some conflicts, but nothing
serious, back to 14.  Unfortunately, 13 lacks requisite infrastructure,
so I think it'll have to stay as it is.  (12 is dead.)

Can you please verify that my explanation in the commit message is
sound?

Thanks

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Cada quien es cada cual y baja las escaleras como quiere" (JMSerrat)

Attachments:

  [text/x-diff] v11-0001-Be-more-picky-with-WAL-segment-deletion-in-pg_re.patch (0B, ../202411121918.beiyanf6gfnb@alvherre.pgsql/2-v11-0001-Be-more-picky-with-WAL-segment-deletion-in-pg_re.patch)
  download

view thread (50+ messages)  latest in thread

Message-ID: <202411121918.beiyanf6gfnb@alvherre.pgsql>
Permalink:  ../202411121918.beiyanf6gfnb@alvherre.pgsql/
Also on:    postgresql.org/message-id/202411121918.beiyanf6gfnb@alvherre.pgsql

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: alvherre@alvh.no-ip.org, cyberdemn@gmail.com, kou@clear-code.com, smithpb2250@gmail.com, torikoshia@oss.nttdata.com, horikyota.ntt@gmail.com, michael@paquier.xyz, pgsql-hackers@postgresql.org, bungina@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: pg_rewind WAL segments deletion pitfall
  In-Reply-To: <202411121918.beiyanf6gfnb@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox