From: Álvaro Herrera <alvherre@alvh.no-ip.org>
To: Euler Taveira <euler@eulerto.com>
Cc: Tender Wang <tndrwang@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: tharakan@gmail.com, pgsql-bugs@lists.postgresql.org, Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Re: BUG #18866: Running pg_freespace() on views triggers an Abort
Date: Wed, 26 Mar 2025 18:33:42 +0100
Message-ID: <202503261733.mcrnkm6myu6y@alvherre.pgsql> (raw)
In-Reply-To: <b6ea023a-703d-4afa-8561-9e867db1b5f0@app.fastmail.com>
On 2025-Mar-25, Euler Taveira wrote:
> On Tue, Mar 25, 2025, at 10:18 PM, Tender Wang wrote:
> > Thanks for the advice. Please see the attached patch.
>
> Your patch needs some adjustments. There is no need to include pg_class.h.
I think including pg_class.h (which is where RELKIND_HAS_STORAGE() is
defined and where errdetail_relkind_not_supported is declared) is better
than including utils/rel.h, which brings in a whole bunch of additional
stuff in addition to pg_class.h :-)
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end." (2nd Commandment for C programmers)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@alvh.no-ip.org, euler@eulerto.com, tndrwang@gmail.com, tgl@sss.pgh.pa.us, hlinnaka@iki.fi
Subject: Re: BUG #18866: Running pg_freespace() on views triggers an Abort
In-Reply-To: <202503261733.mcrnkm6myu6y@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox