From: Álvaro Herrera <alvherre@kurilemu.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18984: Empty prepared statement from psql \parse triggers assert in PortalRunMulti
Date: Tue, 15 Jul 2025 14:33:14 +0200
Message-ID: <202507151233.n5jw4x3jtc2g@alvherre.pgsql> (raw)
In-Reply-To: <834745.1752555566@sss.pgh.pa.us>
On 2025-Jul-15, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
> > ... I am wondering if we should not just nuke the assertion at the end
> > of PortalRunMulti() instead, relying on the same check done at the
> > beginning of ProcessUtility().
>
> Yeah, I was starting to think about that solution too. Removing
> code seems nicer than adding more.
Yeah, this makes sense to me too. I'd rewrite the comment while at it,
because what's being described as "printing 0 0" no longer occurs in
this form in this place anymore. Maybe we could discuss adding
some commentary to EndCommand where this now happens, but I don't think
we really need it.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/Attachments:
[text/x-diff] 0001-Remove-assertion-in-PortalRunMulti-simplify-comment.patch (0B, ../202507151233.n5jw4x3jtc2g@alvherre.pgsql/2-0001-Remove-assertion-in-PortalRunMulti-simplify-comment.patch)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@kurilemu.de, tgl@sss.pgh.pa.us, michael@paquier.xyz, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18984: Empty prepared statement from psql \parse triggers assert in PortalRunMulti
In-Reply-To: <202507151233.n5jw4x3jtc2g@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox