From: Álvaro Herrera <alvherre@kurilemu.de>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: kristianlejao@gmail.com
Subject: Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c
Date: Fri, 26 Sep 2025 15:34:38 +0200
Message-ID: <202509261330.5acuwmf57rvu@alvherre.pgsql> (raw)
In-Reply-To: <CAPmGK14sTPK4bz9ii_wQ2L6Z+i+zdjPBE7rMHrbiL6uGQdWL=g@mail.gmail.com>
On 2025-Sep-24, Etsuro Fujita wrote:
> I took a quick glance at the patch. My initial comment is: it only
> includes the test case discussed here, but I think it's a good idea to
> add more cases in it (that exercise code paths in
> postgresRecheckForeignScan), as I mentioned upthread. What do you
> think about that? If no objections, I'd like to update it to include
> such cases.
I would like to suggest a different approach: because this patch is
known to fix a server crash in a known case, it would be better to get
the fix (and its corresponding test) pushed as is without further delay.
Additional tests are an excellent idea, but I think we shouldn't make
this patch wait for them. If further fixes are deemed necessary for
those other (thus far hypothetical) tests, we can still make them
afterwards.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@kurilemu.de, etsuro.fujita@gmail.com, sawada.mshk@gmail.com, michael@paquier.xyz, pgsql-bugs@lists.postgresql.org, kristianlejao@gmail.com
Subject: Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c
In-Reply-To: <202509261330.5acuwmf57rvu@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox