public inbox for [email protected]  

help / color / mirror / Atom feed

From: Álvaro Herrera <[email protected]>
To: Vishal Prasanna <[email protected]>
Cc: kurodahayato <[email protected]>
Cc: pgsql-bugs <[email protected]>
Subject: Re: [BUG] Assert failure in ReorderBufferReturnTXN during logical decoding due to leaked specinsert change
Date: Wed, 25 Feb 2026 17:57:59 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 2026-Feb-25, Vishal Prasanna wrote:

> > It looks OK for me. In this case an argument should be reduced from 
> > ReorderBufferResetTXN(), right? It is harmless because the function is a static one.
> 
> Yes, the `specinsert` is no longer needed in
> `ReorderBufferResetTXN()`. Updated the patch where `specinsert`
> cleanup is now handled in the `PG_CATCH()` block of
> `ReorderBufferProcessTXN()`, so it is always freed before the if/else
> branch.

Please don't do this.  Changing the argument list of an exported
function is an ABI break.  That's an OK change to do in branch master
(to keep the interface clean), but for released branches it is not
welcome, because it causes problems for users that have extensions that
call the function and were compiled with its older definition.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [BUG] Assert failure in ReorderBufferReturnTXN during logical decoding due to leaked specinsert change
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox