From: Tom Lane <tgl@sss.pgh.pa.us>
To: Vitali Lovich <vlovich@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17095: ./configure fails thread_test.c when run under TSAN
Date: Thu, 08 Jul 2021 17:42:05 -0400
Message-ID: <2045909.1625780525@sss.pgh.pa.us> (raw)
In-Reply-To: <CAF8PYMiRWgMhFCrd3Gyxj1o=SDx0bj4+mJJyeDF_qkZcnFMPpQ@mail.gmail.com>
References: <17095-374e65bfa8737607@postgresql.org>
<CAF8PYMiRWgMhFCrd3Gyxj1o=SDx0bj4+mJJyeDF_qkZcnFMPpQ@mail.gmail.com>
Vitali Lovich <vlovich@gmail.com> writes:
> I've confirmed the following patch (relative to
> 45b88269a353ad93744772791feb6d01bc7e1e42) resolves the issue. It's
> predicated on the assumption that gcc or clang (or a compiler with the
> relevant builtins) are being used to build this.
You realize of course that that assumption is *completely* untenable.
I'm inclined to say that if -fsanitize=address breaks configure,
then don't include -fsanitize=address in the CFLAGS you give to
configure. It's hardly the first such restriction --- -Werror is
another one you can't inject that way, and I wouldn't be surprised
if there are more.
FWIW, I don't particularly agree with TSAN about the code being
incorrect. On what platform is a fetch or a store of an int
not atomic? (If there is one, Postgres will malfunction on it
anyway.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, vlovich@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17095: ./configure fails thread_test.c when run under TSAN
In-Reply-To: <2045909.1625780525@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox