From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Maxim Boguk <maxim.boguk@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18387: Erroneous permission checks and/or misleading error messages with refresh materialized view
Date: Wed, 13 Mar 2024 14:32:55 -0400
Message-ID: <2076079.1710354775@sss.pgh.pa.us> (raw)
In-Reply-To: <ZfHdeer_0QxksV5p@momjian.us>
References: <18387-12041858d9efb6f6@postgresql.org>
<36bb333d-13ec-4f8e-af33-48249ca2fe69@iki.fi>
<CAK-MWwQBrjfAPu=nfWS9B_Y5QK147xU2Y-EpDYAvsrdni97HCw@mail.gmail.com>
<09970dbb6f95a34d9427c32b09517ea709c77d02.camel@cybertec.at>
<ZfHdeer_0QxksV5p@momjian.us>
Bruce Momjian <bruce@momjian.us> writes:
> On Tue, Mar 12, 2024 at 01:22:33PM +0100, Laurenz Albe wrote:
>> I don't see why it should be a problem if a superuser gets
>> "permission denied" in such a case. They can also get it if
>> they call a SECURITY DEFINER function owned by a non-superuser.
> Can we improve the error that superusers get so they realize how to fix
> it?
I think there's been a policy of being minimalistic on
permission-denied errors to avoid giving away security information,
but I'm not sure how much sense that really makes. We already show
the specific object that didn't have permissions. I think it would
be good for these errors to also mention the specific role whose
permissions were checked. Perhaps also show the specific privileges
that were missing --- although it might be hard to do that in a
non-confusing way for complicated cases, such as queries that are
valid if you have either table- or column-level permissions.
If we just add the role I'd envision
ERROR: permission denied to role "foo" for [object]
although with any more detail that would get too long.
Another way could be
ERROR: permission denied for [object]
DETAIL: Role "foo" lacks permission [permission].
Mentioning the role that was checked should address the concern
of "I'm a superuser, why did I get this error?". However,
fixing it requires knowing which privilege to grant. I'm not
sure if that's always obvious.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, bruce@momjian.us, laurenz.albe@cybertec.at, maxim.boguk@gmail.com, hlinnaka@iki.fi, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18387: Erroneous permission checks and/or misleading error messages with refresh materialized view
In-Reply-To: <2076079.1710354775@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox