pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: krujkov@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #15857: Parallel Hash Join makes join instead of exists
Date: Tue, 18 Jun 2019 09:17:02 -0400
Message-ID: <20972.1560863822@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKGKcPcayiknzwx5BAo41cs-ymtLk6b8Ebg7fjXsVMvmcUQ@mail.gmail.com>
References: <15857-d1ba2a64bce0795e@postgresql.org>
	<CA+hUKGLEAYVfd6O=6TRx6e3sJLZwHmPJ=gyJCaMTgixbtvSOFw@mail.gmail.com>
	<CA+hUKG+AT83m_r_N-StwcTC4p5U0ZH12SCbmOn2E54p9aWKiTg@mail.gmail.com>
	<CA+hUKGKcPcayiknzwx5BAo41cs-ymtLk6b8Ebg7fjXsVMvmcUQ@mail.gmail.com>

Thomas Munro <thomas.munro@gmail.com> writes:
> Here's a tidier version with a comment and commit message.

It seems a little weird to make the join-type test be the first one
in the if() condition: it doesn't seem like the most important thing
to test, and it doesn't agree with the way you've worded the comment.
Otherwise +1.

			regards, tom lane

view thread (10+ messages)  latest in thread

Message-ID: <20972.1560863822@sss.pgh.pa.us>
Permalink:  ../20972.1560863822@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/20972.1560863822@sss.pgh.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15857: Parallel Hash Join makes join instead of exists
  In-Reply-To: <20972.1560863822@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox