From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Richard Guo <guofenglinux@gmail.com>
Cc: pgsql-bugs@postgresql.org
Subject: Re: hashing bpchar for nondeterministic collations is broken
Date: Fri, 02 Dec 2022 16:49:16 -0500
Message-ID: <2137318.1670017756@sss.pgh.pa.us> (raw)
In-Reply-To: <b1c12dfa471f9fa98faee3b30bcae7911f397ddb.camel@j-davis.com>
References: <eb83d0ac7b299eb08f9b900dd08a5a0c5d90e517.camel@j-davis.com>
<CAMbWs48dYCWaMaPxFCC4hDTf5ZOFX1xcDdAs4kuPq1b7CCTDAA@mail.gmail.com>
<b1c12dfa471f9fa98faee3b30bcae7911f397ddb.camel@j-davis.com>
Jeff Davis <pgsql@j-davis.com> writes:
> But assuming someone does use that combination of features in 15.1, and
> we release 15.2 with my fix in it, then the consequences could be
> severe: a pg_dump with default options on their bpchar-
> nondeterministic-collation-hash-partitioned table in 15.1 would be
> unrestorable in 15.2. They'd need to take a new pg_dump from 15.1 with
> "--load-via-partition-root" and then restore it in 15.2. Obviously that
> would be bad in any case, but it's more tolerable going between servers
> of different major versions.
Yeah. Also, do we have this issue with hash indexes? If so
reindexing might be necessary, which again would be more
palatable in a major release.
> So, given that this fix is unlikely to help many people in 15 and
> earlier, and that there's a chance that the fix is really painful for
> someone; I'm electing not to backpatch it.
+1
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql@j-davis.com, guofenglinux@gmail.com
Subject: Re: hashing bpchar for nondeterministic collations is broken
In-Reply-To: <2137318.1670017756@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox