From: Tom Lane <tgl@sss.pgh.pa.us>
To: Floris Van Nee <florisvannee@Optiver.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Cc: Andres Freund <andres@anarazel.de>
Subject: Re: error "can only drop stats once" brings down database
Date: Tue, 20 Feb 2024 13:49:07 -0500
Message-ID: <215498.1708454947@sss.pgh.pa.us> (raw)
In-Reply-To: <b14ae28029f64757bb64613be2549a74@Optiver.com>
References: <b14ae28029f64757bb64613be2549a74@Optiver.com>
Floris Van Nee <florisvannee@Optiver.com> writes:
> Hi,
> On a database we have we've recently seen a fatal error occur twice. The error happened on two different physical replicas (of the same cluster) during a WAL redo action in the recovery process. They're running Postgres 15.5.
> Occurrence 1:
> 2024-02-01 06:55:54.476 CET,,,70290,,65a29b60.11292,6,,2024-01-13 15:17:04 CET,1/0,0,FATAL,XX000,"can only drop stats once",,,,,"WAL redo at A7BD1/D6F9B6C0 for Transaction/COMMIT: 2024-02-01 06:55:54.395851+01; ...
Hmm. This must be coming from pgstat_drop_entry_internal.
I suspect the correct fix is in pgstat_drop_entry, along
the lines of
- if (shent)
+ if (shent && !shent->dropped)
but it's not clear to me how the already-dropped case ought to affect
the function's bool result. Also, how are we getting into a
concurrent-drop situation in recovery?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, florisvannee@Optiver.com, pgsql-bugs@lists.postgresql.org, andres@anarazel.de
Subject: Re: error "can only drop stats once" brings down database
In-Reply-To: <215498.1708454947@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox