pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Dmitry Astapov <dastapov@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17619: AllocSizeIsValid violation in parallel hash join
Date: Fri, 23 Sep 2022 19:19:33 -0400
Message-ID: <2169849.1663975173@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKGL1OuDjd5EipFwUnKxKUTWZLhLssBHLOj4Vzo46M9XCYw@mail.gmail.com>
References: <17619-0de62ceda812b8b5@postgresql.org>
	<CA+hUKGKu3xSP7JsRGHw0d2Lxe_e4Y-3bf_1dkgAZj7xcsG=q1w@mail.gmail.com>
	<CAFQUnFiiPUOWihzjH7gevyaGGnX3tskr_3YFtNhv-AzpzY-jrg@mail.gmail.com>
	<CAFQUnFgvgfnwrPQ8j4DSeAHUoZy=FbG9nhBCakrnUQ8KuyRZJg@mail.gmail.com>
	<CAFQUnFhEFTaMafweOG2P7FNToLeiDFrsYRfSBk7TrrkTv+3fMA@mail.gmail.com>
	<CA+hUKGL1OuDjd5EipFwUnKxKUTWZLhLssBHLOj4Vzo46M9XCYw@mail.gmail.com>

Thomas Munro <thomas.munro@gmail.com> writes:
> While testing with that module I found another bug: the
> per-participant npages counter was not explicitly initialised to zero
> in sts_initialize().  That wasn't exactly a problem when the code was
> written because new DSM memory is always zeroed and this always
> happens in new DSM memory, but it shows up in this test module because
> it uses palloc() memory instead.  It *is* a problem since v14, if you
> use min_dynamic_shared_memory for a pool of recyclable shared memory,
> because then it is not zeroed.

That's a fairly scary observation.  What other places are silently
expecting such memory to be zeroed?  Do we need to fix things so
that min_dynamic_shared_memory doesn't break this API?

			regards, tom lane





view thread (21+ messages)  latest in thread

Message-ID: <2169849.1663975173@sss.pgh.pa.us>
Permalink:  ../2169849.1663975173@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2169849.1663975173@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, dastapov@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17619: AllocSizeIsValid violation in parallel hash join
  In-Reply-To: <2169849.1663975173@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox