From: Tom Lane <tgl@sss.pgh.pa.us>
To: Regina Obe <lr@pcorp.us>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16920: Can't compile PostGIS with MingW64 against PostgreSQL 14 head
Date: Thu, 11 Mar 2021 11:37:11 -0500
Message-ID: <2294904.1615480631@sss.pgh.pa.us> (raw)
In-Reply-To: <000501d71691$c616a200$5243e600$@pcorp.us>
References: <16920-2332590daf58407c@postgresql.org>
<2291040.1615474929@sss.pgh.pa.us>
<000501d71691$c616a200$5243e600$@pcorp.us>
"Regina Obe" <lr@pcorp.us> writes:
> From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
>> Hmm, our mingw64 buildfarm animals aren't detecting any particular
>> problem here. Is PostGIS doing anything unusual with injecting special
>> symbols via -D switches? Or maybe including something else before
>> postgres.h? The symptoms look like a header-inclusion-order problem ...
> The order in one of the problem files looks like this:
> Starting:
> https://git.osgeo.org/gitea/postgis/postgis/src/branch/master/postgis/lwgeom
> _in_gml.c#L50
> #include <libxml/tree.h>
> #include <libxml/parser.h>
> #include <libxml/xpath.h>
> #include <libxml/xpathInternals.h>
> #include "postgres.h"
> #include "executor/spi.h"
> #include "utils/builtins.h"
> #include "../postgis_config.h"
> #include "lwgeom_pg.h"
> #include "liblwgeom.h"
> #include "lwgeom_transform.h"
Our usual recommendation is to include postgres.h before all else;
is there a really good reason to be pulling in libxml headers before
that?
Having seen this, I now guess that your issue is happening because
one of those headers has already included <sys/stat.h> before
win32_port.h tries to do so. That makes our attempt to relabel the
system's "struct stat" as "struct microsoft_native_stat" not work.
In general, the portability hacks that postgres.h does for some
platforms aren't reliable if any system headers have already been
pulled in.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, lr@pcorp.us, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16920: Can't compile PostGIS with MingW64 against PostgreSQL 14 head
In-Reply-To: <2294904.1615480631@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox