From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Smith <smithpb2250@gmail.com>
Cc: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18558: ALTER PUBLICATION fails with unhelpful error on attempt to use system column
Date: Sun, 28 Jul 2024 23:01:16 -0400
Message-ID: <2460423.1722222076@sss.pgh.pa.us> (raw)
In-Reply-To: <CAHut+PtDehGqTDo24+jYQ_eo33geJ_4X+ObkFpw18SU_a6U6pw@mail.gmail.com>
References: <18558-411bc81b03592125@postgresql.org>
<CAHut+Pt88zYZfWLj6jnMrQw1CwxeYtp1TmF7vrZ2F6Cyvb=5yQ@mail.gmail.com>
<2455740.1722219823@sss.pgh.pa.us>
<CAHut+PtDehGqTDo24+jYQ_eo33geJ_4X+ObkFpw18SU_a6U6pw@mail.gmail.com>
Peter Smith <smithpb2250@gmail.com> writes:
> On Mon, Jul 29, 2024 at 12:23 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Agreed on that, but shouldn't this patch also be removing some code
>> from the ALTER ... SET path? Or is that part of the cleanup you
>> handwaved about?
> I was thinking that if publication_translate_columns() is modified to
> return the BMS, which it is building internally anyway, then we avoid
> processing the column list 2x. Then the above ALTER SET code can be
> removed. Is that the same code ("shouldn't this patch also be removing
> some code") you were referring to?
If publication_translate_columns is already building that exact same
BMS, then yeah we're on the same page. I hadn't checked the code to
see.
If you'd have to add code to publication_translate_columns, then maybe
it'd be better to make AlterPublicationTables build the BMS from what
publication_translate_columns returns presently.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, smithpb2250@gmail.com, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18558: ALTER PUBLICATION fails with unhelpful error on attempt to use system column
In-Reply-To: <2460423.1722222076@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox