agora inbox for pgsql-bugs@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrey Rachitskiy <pl0h0yp1@gmail.com>
Cc: i.portnov@compassplus.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19487: Error while executing SQL query involving XML parsing
Date: Sat, 29 Aug 2026 17:44:31 -0400
Message-ID: <255521.1788039871@sss.pgh.pa.us> (raw)
In-Reply-To: <CAB8bMisnPP=Ck=BX4UfHL1eTFLMFJ_RznsVXtqy3H=P+6tugjg@mail.gmail.com>
References: <19487-367258bc497b923a@postgresql.org>
<CAB8bMisngV0L9L3dZkpuStTboHXkVPr0=NBhCNpDxg3r+Bheog@mail.gmail.com>
<1589702.1787946553@sss.pgh.pa.us>
<CAB8bMitYCBLs16zVzNLgB34go2s4p9mraGsvcuDeUKyO+a4=cA@mail.gmail.com>
<CAB8bMisnPP=Ck=BX4UfHL1eTFLMFJ_RznsVXtqy3H=P+6tugjg@mail.gmail.com>
Andrey Rachitskiy <pl0h0yp1@gmail.com> writes:
> In v2, I tried to take all the points into account and expanded the tests.
Hmm, I think it might be better to drop
map_sql_value_to_xml_is_immutable and just treat XMLELEMENT and
XMLFOREST as non-immutable. Trying to be smarter adds quite a bit
of complexity to this patch as well as long-term maintenance risk
(ie, needing to keep map_sql_value_to_xml_is_immutable in step with
the actual behavior of map_sql_value_to_xml; if we mess that up, the
mistake will be very non-obvious, and these test cases are unlikely
to catch it). For my money it's not worth it.
regards, tom lane
view thread (11+ messages) latest in thread
Message-ID: <255521.1788039871@sss.pgh.pa.us>
Permalink: ../255521.1788039871@sss.pgh.pa.us/
Also on: postgresql.org/message-id/255521.1788039871@sss.pgh.pa.us
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, pl0h0yp1@gmail.com, i.portnov@compassplus.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19487: Error while executing SQL query involving XML parsing
In-Reply-To: <255521.1788039871@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox