From: Tom Lane <tgl@sss.pgh.pa.us>
To: drakonard@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16661: Changing columns after the rule is created leads to an error when the RETURNING is used
Date: Thu, 08 Oct 2020 13:30:10 -0400
Message-ID: <2576538.1602178210@sss.pgh.pa.us> (raw)
In-Reply-To: <16661-01a98a6c58c8054a@postgresql.org>
References: <16661-01a98a6c58c8054a@postgresql.org>
PG Bug reporting form <noreply@postgresql.org> writes:
> The SQL:
> CREATE TABLE rule_bug_table (
> id serial NOT NULL PRIMARY KEY,
> archived boolean NOT NULL
> );
> CREATE OR REPLACE RULE rule_bug_table__archive_instead_of_delete__rule
> AS ON DELETE TO rule_bug_table
> DO INSTEAD
> UPDATE rule_bug_table
> SET archived = true
> WHERE rule_bug_table."id" = OLD."id"
> RETURNING OLD.*;
> ALTER TABLE rule_bug_table ADD COLUMN select_allowed boolean NOT NULL
> DEFAULT (false);
> DELETE FROM rule_bug_table WHERE id = 1 RETURNING *;
> gives an error "could not find replacement targetlist entry for attno 3".
Hmm. The error message definitely needs to be more user-friendly,
but I don't think this is actually a bug. The rule's RETURNING clause
expands to this during parsing:
RETURNING old.id, old.archived
as you can see with "\d+ rule_bug_table". Then when you try to do
"RETURNING *" in the DELETE, that's asking for a column not available
from the rewritten query. So you *should* get an error, just not one
that looks like it's an internal failure.
The root issue here is that "*" is expanded at parse time for stored
rules and views. Unfortunately, that behavior is specifically demanded
by the SQL spec (at least for the view case), so I doubt we can change it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, drakonard@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16661: Changing columns after the rule is created leads to an error when the RETURNING is used
In-Reply-To: <2576538.1602178210@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox