pg.ddx.io pgsql-bugs@postgresql.org mailing list archive
help / color / mirror / Atom feedBUG #18672: failing to link postgresql
3+ messages / 3 participants
[nested] [flat]
* BUG #18672: failing to link postgresql
@ 2024-10-24 18:35 PG Bug reporting form <noreply@postgresql.org>
0 siblings, 1 reply; 3+ messages in thread
From: PG Bug reporting form @ 2024-10-24 18:35 UTC (permalink / raw)
To: pgsql-bugs@lists.postgresql.org; +Cc: bastian.thierry@laposte.net
The following bug has been logged on the website:
Bug reference: 18672
Logged by: Thierry Bastian
Email address: bastian.thierry@laposte.net
PostgreSQL version: 16.4
Operating system: macOS
Description:
In short, in src/interfaces/libpq/Makefile there is a check for lib-a to not
contain a call to exit. But the issue is that on macOS, it still uses
_atexit and pthread_exitm which are fine.
My fix to this is to apply the following patch:
inline patch 1: src/interfaces/libpq/Makefile (+1/-1 lines) download inline-1.patch
diff --git a/src/interfaces/libpq/Makefile b/src/interfaces/libpq/Makefile
index 0919d8f..65b07d3 100644
--- a/src/interfaces/libpq/Makefile
+++ b/src/interfaces/libpq/Makefile
@@ -118,7 +118,7 @@ backend_src = $(top_srcdir)/src/backend
libpq-refs-stamp: $(shlib)
ifneq ($(enable_coverage), yes)
ifeq (,$(filter aix solaris,$(PORTNAME)))
- @if nm -A -u $< 2>/dev/null | grep -v __cxa_atexit | grep exit; then \
+ @if nm -A -u $< 2>/dev/null | grep -v __cxa_atexit | grep -v _atexit |
* Re: BUG #18672: failing to link postgresql
@ 2024-10-24 20:30 Tom Lane <tgl@sss.pgh.pa.us>
parent: PG Bug reporting form <noreply@postgresql.org>
0 siblings, 1 reply; 3+ messages in thread
From: Tom Lane @ 2024-10-24 20:30 UTC (permalink / raw)
To: bastian.thierry@laposte.net; +Cc: pgsql-bugs@lists.postgresql.org
PG Bug reporting form <noreply@postgresql.org> writes:
> In short, in src/interfaces/libpq/Makefile there is a check for lib-a to not
> contain a call to exit. But the issue is that on macOS, it still uses
> _atexit and pthread_exitm which are fine.
Nobody else has reported any such problem. What build modifications
did you make to cause this?
regards, tom lane
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: BUG #18672: failing to link postgresql
@ 2024-10-28 10:49 Thierry Bastian <bastian.thierry@laposte.net>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 3+ messages in thread
From: Thierry Bastian @ 2024-10-28 10:49 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-bugs@lists.postgresql.org
Hello Tom and thank you for the feedback.
I believe that comes from the fact that I build openssl myself and I build static libs. That makes it so some additional symbols are pulled in.
Regards,
Thierry Bastian
> On 24 Oct 2024, at 22:30, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> PG Bug reporting form <noreply@postgresql.org> writes:
>> In short, in src/interfaces/libpq/Makefile there is a check for lib-a to not
>> contain a call to exit. But the issue is that on macOS, it still uses
>> _atexit and pthread_exitm which are fine.
>
> Nobody else has reported any such problem. What build modifications
> did you make to cause this?
>
> regards, tom lane
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-10-28 10:49 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-10-24 18:35 BUG #18672: failing to link postgresql PG Bug reporting form <noreply@postgresql.org>
2024-10-24 20:30 ` Tom Lane <tgl@sss.pgh.pa.us>
2024-10-28 10:49 ` Thierry Bastian <bastian.thierry@laposte.net>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox