pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Chapman Flack <chap@anastigmatix.net>
Cc: mostafa_bit0108@hotmail.com, pgsql-bugs@lists.postgresql.org, Markus Winand <markus.winand@winand.at>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Subject: Re: BUG #16046: xpath returns CDATA tag along with the value in postgres 12
Date: Fri, 25 Oct 2019 13:27:52 -0400
Message-ID: <27892.1572024472@sss.pgh.pa.us> (raw)
In-Reply-To: <5DB253C8.4020501@anastigmatix.net>
References: <16046-a04d0611e7a0c03a@postgresql.org>
	<10621.1571953091@sss.pgh.pa.us>
	<5DB23068.3080601@anastigmatix.net>
	<5DB253C8.4020501@anastigmatix.net>

Chapman Flack <chap@anastigmatix.net> writes:
> On 10/24/19 19:14, Chapman Flack wrote:
>> Which may or may not be a good thing. Perhaps it could lead the unwary
>> in some cases to think such a query is giving a directly usable
>> text string back, which will be harmless until the one time a value
>> with escaping comes back. (The no-surprises way to get back a directly
>> usable text string, if that's what's wanted, would be with XMLTABLE
>> and an output column of text type.)

> If the original reporter is happy with getting xml back, instead of
> raw text, but only wants the form of escaping to be the same as it was
> in pg11, the xpath //cname/aname/text() can just be rewritten as
> string(//cname/aname), which will lose any CDATA-ness and consistently
> produce the form where individual characters are escaped, in 11 or 12.

> I think.

Yeah, that does work the same for me in 11 and HEAD:

regression=# SELECT unnest(xpath('string(//cname/aname)','<cname><aname><![CDATA[select 5>4]]></aname></cname>'::xml));
    unnest     
---------------
 select 5&gt;4
(1 row)

So I'm inclined to write this off as an intended, or at least not
unwanted, change.  However, this complaint does reinforce Alvaro's
original choice not to back-patch 251cf2e27.

The v12 release notes don't call this out as a compatibility issue,
nor mention anything about CDATA handling:

  * Fix assorted bugs in XML functions (Pavel Stehule, Markus Winand,
    Chapman Flack)

    Specifically, in XMLTABLE, xpath(), and xmlexists(), fix some cases
    where nothing was output for a node, or an unexpected error was
    thrown, or necessary escaping of XML special characters was omitted.

Should we extend that item (if so, what to say exactly?) and/or move
it into the "Observe the following incompatibilities" list?

			regards, tom lane





view thread (9+ messages)  latest in thread

Message-ID: <27892.1572024472@sss.pgh.pa.us>
Permalink:  ../27892.1572024472@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/27892.1572024472@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, chap@anastigmatix.net, markus.winand@winand.at, pavel.stehule@gmail.com
  Subject: Re: BUG #16046: xpath returns CDATA tag along with the value in postgres 12
  In-Reply-To: <27892.1572024472@sss.pgh.pa.us>
  References: <16046-a04d0611e7a0c03a@postgresql.org> <10621.1571953091@sss.pgh.pa.us> <5DB23068.3080601@anastigmatix.net> <5DB253C8.4020501@anastigmatix.net> <27892.1572024472@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox