pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: wenjing <wjzeng2012@gmail.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: Euler Taveira <euler.taveira@2ndquadrant.com>
Cc: pgsql-bugs@lists.postgresql.org, tushar <tushar.ahuja@enterprisedb.com>
Cc: Prabhat Sahu <prabhat.sahu@enterprisedb.com>
Subject: Re: [bug] Wrong bool value parameter
Date: Sat, 11 Apr 2020 11:25:13 -0400
Message-ID: <27959.1586618713@sss.pgh.pa.us> (raw)
In-Reply-To: <ED2A8D63-1AD7-40B2-8019-18CD206697C6@gmail.com>
References: <C6E8C2E7-1906-4F6E-BCC8-7D9FC2FC5CFE@gmail.com>
	<CAH503wA1_burFuRPQkBfMdHXQoc_13R6wmQ06LkjfKN1SHQpSQ@mail.gmail.com>
	<CA+fd4k7zmTWzmZP6xPey=KZ2EtBOY+T6mnrLewjL4XV=n0s+og@mail.gmail.com>
	<ED2A8D63-1AD7-40B2-8019-18CD206697C6@gmail.com>

wenjing <wjzeng2012@gmail.com> writes:
> 2020年4月7日 22:35,Masahiko Sawada <masahiko.sawada@2ndquadrant.com> 写道:
>>> I'm not sure it is a bug. It certainly can be an improvement. Code as is does not cause issues although I concur with you that it is at least a strange syntax. It is like this at least since 2009 (commit ba748f7a11e). I'm not sure parse_bool* is the right place to fix it because it could break code. IMHO the problem is that parse_one_reloption() is using the value provided by user; it should test those (abbreviation) conditions and store "true" (for example) as bool value.

> It seems difficult to store a new bool value in parse_one_reloption. This is a string stored with ”autovacuum_enabled =“.
> any other ideas?

I don't think we should touch this.  If the user chose to write the value
in a specific way, they might've had a reason for that.  There's little
reason for us to override it, certainly not enough to justify introducing
a lot of new mechanism just to do that.

			regards, tom lane





view thread (9+ messages)

Message-ID: <27959.1586618713@sss.pgh.pa.us>
Permalink:  ../27959.1586618713@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/27959.1586618713@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, wjzeng2012@gmail.com, masahiko.sawada@2ndquadrant.com, euler.taveira@2ndquadrant.com, tushar.ahuja@enterprisedb.com, prabhat.sahu@enterprisedb.com
  Subject: Re: [bug] Wrong bool value parameter
  In-Reply-To: <27959.1586618713@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox