From: Tom Lane <tgl@sss.pgh.pa.us>
To: Richard Guo <guofenglinux@gmail.com>
Cc: vasiliy.boytsov@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18576: Using EXPLAIN (VERBOSE) in information_schema.element_types returns ERROR: failed to find plan for
Date: Fri, 09 Aug 2024 11:25:27 -0400
Message-ID: <2799439.1723217127@sss.pgh.pa.us> (raw)
In-Reply-To: <2548861.1723174234@sss.pgh.pa.us>
References: <18576-9feac34e132fea9e@postgresql.org>
<CAMbWs49gOeyotM7riJ-q_NgLgfA6-3z7DffnR71kSyaHTkh2ig@mail.gmail.com>
<2336091.1723137115@sss.pgh.pa.us>
<2493069.1723149304@sss.pgh.pa.us>
<CAMbWs4_Au2i+p2MbZ8nNB_QQXrFy65CXNeJL11j2WJbNW18fHQ@mail.gmail.com>
<2548861.1723174234@sss.pgh.pa.us>
I wrote:
> Richard Guo <guofenglinux@gmail.com> writes:
>> Agreed. Do you think it would be helpful to add some assertions to
>> verify the plan type?
> I thought about that but didn't experiment with it. I wonder whether
> it'd just make the code more fragile. Still, it might be useful to
> verify that things are happening as we expect.
After sleeping on it, I elected to add the Asserts as suggested,
except in v12 where they'd have had to look different. That's
not strictly a matter of laziness: v12's next release will be its
last, and I've been burned often enough to become very hesitant
about pushing even slightly-questionable code into an EOL release.
Pushed with that change.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, guofenglinux@gmail.com, vasiliy.boytsov@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18576: Using EXPLAIN (VERBOSE) in information_schema.element_types returns ERROR: failed to find plan for
In-Reply-To: <2799439.1723217127@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox