pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: David G. Johnston <david.g.johnston@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Nisha Moond <nisha.moond412@gmail.com>
Cc: Gunnar Morling <gunnar.morling@googlemail.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: Unexpected behavior when setting "idle_replication_slot_timeout"
Date: Wed, 9 Jul 2025 01:42:00 +0900
Message-ID: <27bce143-4011-4e83-8b91-392c11d318c8@oss.nttdata.com> (raw)
In-Reply-To: <474268.1751731988@sss.pgh.pa.us>
References: <CADGJaX_0+FTguWpNSpgVWYQP_7MhoO0D8=cp4XozSQgaZ40Odw@mail.gmail.com>
	<CABdArM76e8-XChodqKxEiRK3tR_Yv3cymn_AWfP4bOsLDscZAg@mail.gmail.com>
	<30e91649-06dd-453e-8658-5f4acd03a3bd@oss.nttdata.com>
	<b26f13d7-769a-4b64-8bed-cb3a833c0604@oss.nttdata.com>
	<686577f2379e4b978803e72746dcf0dd7baf3937.camel@cybertec.at>
	<e0789f10-5b48-4d6b-a32c-0f4426d254df@oss.nttdata.com>
	<CAA4eK1LOyUeCHk3hMtjT-bpqXLAnjODwcO+o7+bTnB2es-fSqw@mail.gmail.com>
	<70b183fb-f66e-40d8-b0de-be8c1052fa93@oss.nttdata.com>
	<CAKFQuwYVEgy+fiHMvSoykiEef-VF-ZV9Gxv4rynk9NNK9UMPYQ@mail.gmail.com>
	<472687.1751731008@sss.pgh.pa.us>
	<474268.1751731988@sss.pgh.pa.us>



On 2025/07/06 1:13, Tom Lane wrote:
> I wrote:
>> I'm kind of down on changing the unit, because it will *silently*
>> break configuration files where the value was set without a unit.
> 
> Oh, wait a second.  I just noticed that this variable is new in v18.
> So there won't be a compatibility issue as long as we change it in
> v18 too.  So changing it to a base of seconds seems sufficient,
> and more in line with existing practice:

Yes!

It seems there are currently no clear objections to the patch that
changes the unit of idle_replication_slot_timeout to seconds.
If that's the case, I'm planning to commit it to both master and v18.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation






view thread (38+ messages)  latest in thread

Message-ID: <27bce143-4011-4e83-8b91-392c11d318c8@oss.nttdata.com>
Permalink:  ../27bce143-4011-4e83-8b91-392c11d318c8@oss.nttdata.com/
Also on:    postgresql.org/message-id/27bce143-4011-4e83-8b91-392c11d318c8@oss.nttdata.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, tgl@sss.pgh.pa.us, david.g.johnston@gmail.com, amit.kapila16@gmail.com, laurenz.albe@cybertec.at, nisha.moond412@gmail.com, gunnar.morling@googlemail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: Unexpected behavior when setting "idle_replication_slot_timeout"
  In-Reply-To: <27bce143-4011-4e83-8b91-392c11d318c8@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox