pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Jesper Pedersen <jesper.pedersen@redhat.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15587: Partitions with ALTER TABLE ADD CONSTRAINT
Date: Tue, 15 Jan 2019 13:42:56 -0500
Message-ID: <2815.1547577776@sss.pgh.pa.us> (raw)
In-Reply-To: <201901151824.mxkelqcnfeq6@alvherre.pgsql>
References: <201901151824.mxkelqcnfeq6@alvherre.pgsql>

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2019-Jan-10, Jesper Pedersen wrote:
>> However, when you use ADD CONSTRAINT FOREIGN KEY you can't use ONLY, so
>> would it be a good idea to make ADD CONSTRAINT UNIQUE behave the same way,
>> i.e. error out ?

> I haven't investigated this angle.  It seems more complex than just a
> simple bugfix, right?

Wouldn't that be throwing away the entire point of the ONLY behavior,
ie to allow the component indexes to be built one at a time, without
holding locks across the whole partition tree?

I'm having a hard time getting from "ONLY confuses me" to "nobody
should be allowed to do this".  I think there is a documentation
and UX issue here, but I don't see that there's anything wrong
with the functionality.

			regards, tom lane




view thread (18+ messages)  latest in thread

Message-ID: <2815.1547577776@sss.pgh.pa.us>
Permalink:  ../2815.1547577776@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2815.1547577776@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, jesper.pedersen@redhat.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15587: Partitions with ALTER TABLE ADD CONSTRAINT
  In-Reply-To: <2815.1547577776@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox