From: Tom Lane <tgl@sss.pgh.pa.us>
To: petrum@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15312: Possible access to unintended variable in "postgres/src/backend/postmaster/pgstat.c" line 2698
Date: Tue, 07 Aug 2018 14:45:22 -0400
Message-ID: <28213.1533667522@sss.pgh.pa.us> (raw)
In-Reply-To: <153363913073.1303.6518849192351268091@wrigleys.postgresql.org>
References: <153363913073.1303.6518849192351268091@wrigleys.postgresql.org>
=?utf-8?q?PG_Bug_reporting_form?= <noreply@postgresql.org> writes:
> MemSet(BackendActivityBuffer, 0, size); //HERE
> Shouldn't BackendActivityBufferSize be accessed in the marked line instead
> of size?
Yeah, I think you're right --- looks like a pretty obvious copy-and-paste
oversight. It's probably harmless as long as
pgstat_track_activity_query_size is at least NAMEDATALEN, but it's
not good.
Thanks for reporting that!
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, petrum@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15312: Possible access to unintended variable in "postgres/src/backend/postmaster/pgstat.c" line 2698
In-Reply-To: <28213.1533667522@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox