From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Luke Koops <luke.koops@entrust.com>
Cc: Pg Bugs <pgsql-bugs@postgresql.org>
Subject: Re: BUG #4958: Stats collector hung on WaitForMultipleObjectsEx while attempting to recv a datagram
Date: Wed, 22 Aug 2012 22:24:11 -0400
Message-ID: <28583.1345688651@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoanozBPOBL0qB4OzP4Jn3xJHYaunwwfmRrT1sBZhnSgew@mail.gmail.com>
References: <200907311459.n6VExuSa036743@wwwmaster.postgresql.org>
<CA+TgmoZheGK5AvR8Nw0WPwwxzvfpzFENdCbP_2ennJSBnraEnA@mail.gmail.com>
<1410.1344363743@sss.pgh.pa.us>
<CA+TgmobQ0sLjzHdEQZr9QG7n2r-BKej+UTH7rcPPh09doMvUDg@mail.gmail.com>
<1345576064-sup-7145@alvh.no-ip.org>
<9323.1345581034@sss.pgh.pa.us>
<CA+TgmoanozBPOBL0qB4OzP4Jn3xJHYaunwwfmRrT1sBZhnSgew@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Aug 21, 2012 at 4:30 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Meanwhile, back at the ranch: I'm fine with applying that patch now that
>> it's had some field testing.
> Attached is a version that applies OK to 9.1, after resolving some
> conflicts. Review appreciated. It wasn't exactly clear to me how to
> handle the ereport/elog calls.
It looks sane to me in a quick once-over (bearing in mind I can't test
it). What's bothering you about the ereport calls?
> What to do pre-9.1 is a bit less clear to me, as the latch machinery
> doesn't exist at all in those versions. Some of the fixes can
> probably still be pulled out and applied, though.
Presumably the changes in win32/socket.c could still be applied; but
on the other hand it's not clear there's so much need for them pre-9.1.
IIRC most of the point of this patch was to eliminate the tug-of-war
over the socket's event attachment between socket.c and win32_latch.c,
so maybe there's not a bug pre-9.1.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, alvherre@2ndquadrant.com, luke.koops@entrust.com
Subject: Re: BUG #4958: Stats collector hung on WaitForMultipleObjectsEx while attempting to recv a datagram
In-Reply-To: <28583.1345688651@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox