pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: walther@technowledgy.de, Christophe Pettus <xof@thebuild.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL Bugs <pgsql-bugs@lists.postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: Regression tests fail with musl libc because libpq.so can't be loaded
Date: Tue, 26 Mar 2024 11:45:55 -0400
Message-ID: <2901434.1711467955@sss.pgh.pa.us> (raw)
In-Reply-To: <515199be-2f4d-4e47-9b6e-d3f3ed11e510@eisentraut.org>
References: <CA+hUKGK2cSx3dveMqBD+E9N=zJ0WawBcbk_jnPqmdWBM0DT_3Q@mail.gmail.com>
	<477fa513-6bf0-456d-8d24-1e22a19df671@technowledgy.de>
	<ZfrmN4WHuJgD95fw@momjian.us>
	<CA+hUKGJzC4rr2Yr=QZyx9W83Wv=TVJHndKF1anjNLNXVUM7TqQ@mail.gmail.com>
	<f98cd8de-1c66-491a-8409-e62c09932080@technowledgy.de>
	<36690fcf-f0c8-4d60-af49-6a7efa0e2b14@technowledgy.de>
	<CA+hUKGJAkTZUa9JGr-zsadaqsN=K0P71t-1L2t2=MQFDMc4GuQ@mail.gmail.com>
	<ZfzLsiXbguTDatiZ@momjian.us>
	<a2463df1-be45-4a76-b90f-7676d778e7b1@technowledgy.de>
	<Zf2JU0_GDdbeBm5j@momjian.us>
	<Zf3fnKpHIGpe5mOi@momjian.us>
	<443430b4-0c10-49f3-8c8a-e5e76602f309@eisentraut.org>
	<CA+hUKGKU_0hmqem_EmAwePjVtMrjZNyNN0niUdBhuABajRwyhw@mail.gmail.com>
	<2712381.1711408552@sss.pgh.pa.us>
	<2715727.1711410188@sss.pgh.pa.us>
	<515199be-2f4d-4e47-9b6e-d3f3ed11e510@eisentraut.org>

Peter Eisentraut <peter@eisentraut.org> writes:
> On 26.03.24 00:43, Tom Lane wrote:
>> I looked at the musl source code you identified and confirmed that
>> only the LD_LIBRARY_PATH string is remembered in a static variable;
>> LD_PRELOAD is only accessed locally in that initialization function.
>> So we only need to do the attached.  (I failed to resist the
>> temptation to rewrite the comments.)

> Yeah, I was more looking for a comment for posterity for *why* we need 
> to preserve this variable in particular.  The updated comment looks 
> reasonable.

OK, pushed after a bit more comment-fiddling.

			regards, tom lane





view thread (86+ messages)

Message-ID: <2901434.1711467955@sss.pgh.pa.us>
Permalink:  ../2901434.1711467955@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2901434.1711467955@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter@eisentraut.org, thomas.munro@gmail.com, bruce@momjian.us, xof@thebuild.com, andrew@dunslane.net, pgsql-bugs@lists.postgresql.org, robertmhaas@gmail.com
  Subject: Re: Regression tests fail with musl libc because libpq.so can't be loaded
  In-Reply-To: <2901434.1711467955@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox