pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: Logical replication can be broken by domain constraint with NOT VALID option
Date: Sun, 03 Nov 2019 10:42:13 -0500
Message-ID: <29155.1572795733@sss.pgh.pa.us> (raw)
In-Reply-To: <4bdc6250-03c6-0090-df77-580f998c4547@postgrespro.ru>
References: <4bdc6250-03c6-0090-df77-580f998c4547@postgrespro.ru>

Andrey Lepikhov <a.lepikhov@postgrespro.ru> writes:
> During patch development I ran into a small problem (see attachment, 
> fail_replication.sh):
> 1. We have a table with logical replication to another node.
> 2. On the master and replica add such "NOT VALID" domain constraint on 
> the table  that some tuples  violates the constraint.
> 3. UPDATE the table: set value of the tuple that violates constraint to 
> correct value.
> 4. That's all!

> The reason for this problem is that on UPDATE walsender sends old tuple 
> value (that violates the constraint) with new version (satisfied the 
> constraint).
> Replication worker at replica node restores slot from transfer 
> representation. During this process domain checking constraint and 
> returns an ERROR.

I'm not sure this is something we should attempt to fix.  There are
an infinite number of ways you can break logical replication by
presenting it with inconsistent data, and that's really what you've
done here.

> This problem can be solved by many ways and approaches. I wrote the 
> patch to solve this problem (see in attachment) by the shortest way.

That patch is certainly utterly unacceptable.  It'd allow the
receipient to accept data that violates the domain constraint.

The situation you're describing would probably best be handled by
not adding the constraint on the replica side until all the
bad data has been corrected (and replicated).

			regards, tom lane





view thread (5+ messages)  latest in thread

Message-ID: <29155.1572795733@sss.pgh.pa.us>
Permalink:  ../29155.1572795733@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/29155.1572795733@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, a.lepikhov@postgrespro.ru
  Subject: Re: Logical replication can be broken by domain constraint with NOT VALID option
  In-Reply-To: <29155.1572795733@sss.pgh.pa.us>
  References: <4bdc6250-03c6-0090-df77-580f998c4547@postgrespro.ru> <29155.1572795733@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox