From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Oleksii Kliukin <alexk@hintbits.com>
Cc: pgsql-bugs@lists.postgresql.org, ildus@adjust.com, Chris Travers <chris.travers@adjust.com>
Cc: Nick Babadzhanian <nickb@adjust.com>
Cc: julian.schauder@gmx.de
Subject: Re: postgres crash on concurrent update of inheritance partitioned table
Date: Tue, 28 Jan 2020 17:29:59 -0500
Message-ID: <29583.1580250599@sss.pgh.pa.us> (raw)
In-Reply-To: <20200128170755.bq3f27bfkjpt4d4b@development>
References: <EEF05F66-2871-4786-992B-5F45C92FEE2E@hintbits.com>
<20200128170755.bq3f27bfkjpt4d4b@development>
Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> On Tue, Jan 28, 2020 at 05:17:14PM +0100, Oleksii Kliukin wrote:
>> We have experienced a few crashes a day since upgrading to pg 12.1 last
>> week, during the process of updating an inheritance-partitioned table by
>> several concurrent sessions.
> Yeah, I can reproduce it too. If I had to guess, I'd say it's another
> bug due to
> commit 3fb307bc4a76815f96fec28a0d1525ab3fbbcfb4
> Author: Andres Freund <andres@anarazel.de>
> Date: Mon Sep 9 05:21:30 2019 -0700
> Reorder EPQ work, to fix rowmark related bugs and improve efficiency.
> which introduced relsubs_done et al, and perhaps did not get the life
> cycle / resetting right. Not sure.
Yup, that's it exactly. EvalPlanQualStart was expecting to reuse
relsubs_rowmark and relsubs_done, but that storage will be recycled by
EvalPlanQualEnd because it's in the query context of the recheckestate.
AFAICS the re-use has no semantic value, so I just got rid of it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, tomas.vondra@2ndquadrant.com, andres@anarazel.de, alexk@hintbits.com, chris.travers@adjust.com, nickb@adjust.com, julian.schauder@gmx.de
Subject: Re: postgres crash on concurrent update of inheritance partitioned table
In-Reply-To: <29583.1580250599@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox