From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: postgresql@taljaren.se, pgsql-hackers@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
Subject: Re: BUG #17717: Regression in vacuumdb (15 is slower than 10/11 and possible memory issue)
Date: Fri, 06 Jan 2023 12:53:07 -0500
Message-ID: <3018167.1673027587@sss.pgh.pa.us> (raw)
In-Reply-To: <20221229213719.GA301584@nathanxps13>
References: <3544447.1671141436@sss.pgh.pa.us>
<CAH2-WzkXmYt-K+pQqMqjFgwU7jiykD3amngd5-jkqQF=gST7Og@mail.gmail.com>
<3672943.1671202149@sss.pgh.pa.us>
<CAH2-WzkHRxcE-0Mub9N0Rr09SGEEF1Ex4pUbcOBSRoNGNVy93w@mail.gmail.com>
<407579.1672258403@sss.pgh.pa.us>
<20221229012354.GF1153@telsasoft.com>
<451605.1672280274@sss.pgh.pa.us>
<576868.1672334578@sss.pgh.pa.us>
<20221229182657.GA165622@nathanxps13>
<599741.1672345755@sss.pgh.pa.us>
<20221229213719.GA301584@nathanxps13>
Nathan Bossart <nathandbossart@gmail.com> writes:
> On Thu, Dec 29, 2022 at 03:29:15PM -0500, Tom Lane wrote:
>> I tried to make a patch along these lines, and soon hit a stumbling
>> block: ONLY is a fully-reserved SQL keyword. I don't think this
>> syntax is attractive enough to justify requiring people to
>> double-quote the option, so we are back to square one. Anybody
>> have a different suggestion?
> ... adding both SKIP_DATABASE_STATS and ONLY_DATABASE_STATS might be the
> best bet.
Nobody has proposed a different bikeshed color, so I'm going to
proceed with that syntax. I'll incorporate the parallel-machinery
fix from your patch and push to HEAD only (since it's hard to argue
this isn't a new feature).
This needn't foreclose pursuing the various ideas about making
vac_update_datfrozenxid faster; but none of those would eliminate
the fundamental O(N^2) issue AFAICS.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, nathandbossart@gmail.com, pryzby@telsasoft.com, pg@bowt.ie, michael@paquier.xyz
Subject: Re: BUG #17717: Regression in vacuumdb (15 is slower than 10/11 and possible memory issue)
In-Reply-To: <3018167.1673027587@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox