pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: buschmann@nidsa.net
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16045: vacuum_db crash and illegal memory alloc after pg_upgrade from PG11 to PG12
Date: Thu, 10 Oct 2019 10:19:12 -0400
Message-ID: <30706.1570717152@sss.pgh.pa.us> (raw)
In-Reply-To: <20191010134303.bkwjzchjb2w66iro@development>
References: <16045-673e8fa6b5ace196@postgresql.org>
	<20191009132436.uugh4r3be6vw6ex4@development>
	<20191009135907.km2b5nrzflcz6xey@development>
	<20191009141841.my6k44wfiaquj3ks@development>
	<20191009230759.ge66neof5qj627a2@development>
	<19314.1570663125@sss.pgh.pa.us>
	<20191009232836.jg77wccqwy5fgs6s@development>
	<20265.1570664514@sss.pgh.pa.us>
	<20191010014813.3b2btmkakhrskwgd@alap3.anarazel.de>
	<20191010134303.bkwjzchjb2w66iro@development>

Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> Fair enough, attached is a patch doing that, I think. Maybe the file
> should be named differently, as it contains other objects than just
> tables.

Seems about right, though I notice it will not detect domains over
sql_identifier.  How much do we care about that?

To identify such domains, I think we'd need something like
WHERE attypid IN (recursive-WITH-query), which makes me nervous.
We did support those starting with 8.4, which is as far back as
pg_upgrade will go, so in theory it should work.  But I think we
had bugs with such cases in old releases.  Do we want to assume
that the source server has been updated enough to avoid any such
bugs?  The expense of such a query might be daunting, too.

			regards, tom lane





view thread (30+ messages)  latest in thread

Message-ID: <30706.1570717152@sss.pgh.pa.us>
Permalink:  ../30706.1570717152@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/30706.1570717152@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, tomas.vondra@2ndquadrant.com, andres@anarazel.de, buschmann@nidsa.net, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16045: vacuum_db crash and illegal memory alloc after pg_upgrade from PG11 to PG12
  In-Reply-To: <30706.1570717152@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox