pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: bchen90@163.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16666: Slight memory leak when running pg_ctl reload
Date: Mon, 12 Oct 2020 10:42:27 -0400
Message-ID: <3091770.1602513747@sss.pgh.pa.us> (raw)
In-Reply-To: <20201012141938.GB24889@momjian.us>
References: <16666-2c41a4eec61b03e1@postgresql.org>
	<20201012141938.GB24889@momjian.us>

Bruce Momjian <bruce@momjian.us> writes:
> Uh, you are saying pg_ctl leaks memory or the database server leaks
> memory?  I don't see any memory allocation in the code you posted.

I've not looked at the code yet, but I think the OP is worried that
we need to free(newval) before these "return"s.

			regards, tom lane





view thread (4+ messages)  latest in thread

Message-ID: <3091770.1602513747@sss.pgh.pa.us>
Permalink:  ../3091770.1602513747@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3091770.1602513747@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, bruce@momjian.us, bchen90@163.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16666: Slight memory leak when running pg_ctl reload
  In-Reply-To: <3091770.1602513747@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox