From: Tom Lane <tgl@sss.pgh.pa.us>
To: bianpan2016@163.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15539: Deadcode in OpenTableList
Date: Fri, 07 Dec 2018 11:04:19 -0500
Message-ID: <30955.1544198659@sss.pgh.pa.us> (raw)
In-Reply-To: <15539-06d00ef6b1e2e1bb@postgresql.org>
References: <15539-06d00ef6b1e2e1bb@postgresql.org>
=?utf-8?q?PG_Bug_reporting_form?= <noreply@postgresql.org> writes:
> The function OpenTableList performs the condition check " if
> (list_member_oid(relids, childrelid))" twice. The second condition will
> always evaluate to FALSE. As a result, the code (i.e., heap_close) on the
> true branch of the second condition check is deadcode.
Yeah, you're right. I wonder whether we should've expected Coverity
to notice that.
Fix pushed, thanks for the report!
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, bianpan2016@163.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15539: Deadcode in OpenTableList
In-Reply-To: <30955.1544198659@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox