From: Alexander Lakhin <exclusion@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Amit Langote <amitlan@postgresql.org>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18344: Pruning tables partitioned by bool range fails with invalid strategy
Date: Tue, 20 Feb 2024 06:00:00 +0300
Message-ID: <312fb507-9b5e-cf83-d8ed-cd0da72a902c@gmail.com> (raw)
In-Reply-To: <CAApHDvpW6N38TerNpHuvXSZ3NHMpQr+G0R8fqvj1wD9ocCeRsA@mail.gmail.com>
References: <18344-8d3f00bada6d09c6@postgresql.org>
<3263261.1708014503@sss.pgh.pa.us>
<CAApHDvqriy8mPOFJ_Bd66YGXJ4+XULpv-4YdB+ePdCQFztyisA@mail.gmail.com>
<CAApHDvoFbt0fne1C_prK5j0MvxHccJD7NxUY0UDaTtAZuEyxrg@mail.gmail.com>
<3873394.1708273499@sss.pgh.pa.us>
<CAApHDvpW6N38TerNpHuvXSZ3NHMpQr+G0R8fqvj1wD9ocCeRsA@mail.gmail.com>
Hello David,
19.02.2024 02:49, David Rowley wrote:
>
> Here's a more complete patch for this. I included some tests for LIST
> and RANGE partitioned tables. I did manual testing for HASH, and was
> on the fence about covering that too.
>
Thank you for the fix!
Beside that, I'm a bit confused by the opstrategy description for
get_matching_range_bounds().
Above that function we have:
* 'opstrategy' if non-zero must be a btree strategy number.
But as we could see, zero opstrategy is not valid for the function (so
"if non-zero" is meaningless here?), unlike opstrategy for
get_matching_list_bounds(), which has the same description, but the latter
function contains:
/* Special case handling of values coming from a <> operator clause. */
if (opstrategy == InvalidStrategy)
...
Best regards,
Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: exclusion@gmail.com, dgrowleyml@gmail.com, tgl@sss.pgh.pa.us, amitlan@postgresql.org, alvherre@alvh.no-ip.org, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18344: Pruning tables partitioned by bool range fails with invalid strategy
In-Reply-To: <312fb507-9b5e-cf83-d8ed-cd0da72a902c@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox