From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Richard Guo <guofenglinux@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: Assert failure with ICU support
Date: Thu, 20 Apr 2023 15:53:01 -0400
Message-ID: <3170490.1682020381@sss.pgh.pa.us> (raw)
In-Reply-To: <c480b495be592d600504b99e70745ed8f43c877b.camel@j-davis.com>
References: <CAMbWs49Q6UoKGeT8pBkMtJGJd+16CBFZaaWUk9Du+2ERE5g_YA@mail.gmail.com>
<ece303a3068026c6d6f10cab2a7f3f0836f4adb7.camel@j-davis.com>
<3017542.1681937148@sss.pgh.pa.us>
<c480b495be592d600504b99e70745ed8f43c877b.camel@j-davis.com>
Jeff Davis <pgsql@j-davis.com> writes:
> On Wed, 2023-04-19 at 16:45 -0400, Tom Lane wrote:
>> + if (c >= 0x100 || !iscalnum(c))
> I'm curious why you say >= 0x100 rather than >= 0x80?
Right, should be 0x80, my thinko.
> What's the purpose of the error? Is it to catch mistakes, or is it to
> reserve room for adding new escape sequences in the future?
As I read it, it's meant to leave room for defining more escapes.
If we allowed \x for any non-currently-defined "x" to just be "x",
then there would be a compatibility problem if we wanted to make
it mean something else. But I think it's sufficient to reserve
the ASCII letters for that purpose.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql@j-davis.com, guofenglinux@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: Assert failure with ICU support
In-Reply-To: <3170490.1682020381@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox