From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pyry Kontio <pyry.kontio@drasa.eu>
Cc: pgsql-bugs@postgresql.org
Subject: Re: Adding libpgcommon and libpgcore to libpq pkg-config's Requires.private
Date: Mon, 17 Feb 2020 09:04:52 -0500
Message-ID: <32416.1581948292@sss.pgh.pa.us> (raw)
In-Reply-To: <CACS8yHJv+kUdGp0BjOpNCWC+MWU8iUjmFpHFOXv0GXMbLTOZUQ@mail.gmail.com>
References: <CACS8yHJv+kUdGp0BjOpNCWC+MWU8iUjmFpHFOXv0GXMbLTOZUQ@mail.gmail.com>
Pyry Kontio <pyry.kontio@drasa.eu> writes:
> I recently investigated a build with statically linked libpq
> that broke on update to PostgreSQL 12.0.
> The problem was that starting from 12.0, libpq doesn't
> include some required files via symlinks anymore,
> and needs to be linked against libpgcommon and
> libpgcore. (When dynamically linking, this problem
> doesn't manifest.)
Correct.
> However, the pkg-config file for libpq doesn't reflect that fact.
> I think that this should be considered as a bug;
We do not support statically-linked libpq, so this is not a bug.
If you are going to distribute a statically-linked libpq, you can
distribute a modified pkg-config file alongside it, but please
make clear to your users that such a configuration is not standard
Postgres and is not supported or approved by upstream.
The primary reason why I'm pushing back so hard against this is
that in the configuration you suggest, there's no way to avoid
exposing all the cruft in libpgcommon and libpgport to client
applications. That's a horrible situation and will inevitably
lead to ABI problems. Which we will *NOT* acknowledge as being
our bug to deal with, and we are not going to be happy that
you made it possible.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, pyry.kontio@drasa.eu
Subject: Re: Adding libpgcommon and libpgcore to libpq pkg-config's Requires.private
In-Reply-To: <32416.1581948292@sss.pgh.pa.us>
References: <CACS8yHJv+kUdGp0BjOpNCWC+MWU8iUjmFpHFOXv0GXMbLTOZUQ@mail.gmail.com> <32416.1581948292@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox