From: Andrei Lepikhov <a.lepikhov@postgrespro.ru>
To: Tender Wang <tndrwang@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: "type with xxxx does not exist" when doing ExecMemoize()
Date: Mon, 26 Feb 2024 12:38:09 +0700
Message-ID: <32a955a1-1cbb-442e-b903-bcb5982a1e58@postgrespro.ru> (raw)
In-Reply-To: <d3da9856-0394-48e6-9f41-543c589e9585@postgrespro.ru>
References: <CAHewXNnT6N6UJkya0z-jLFzVxcwGfeRQSfhiwA+NyLg-x8iGew@mail.gmail.com>
<d3da9856-0394-48e6-9f41-543c589e9585@postgrespro.ru>
On 26/2/2024 09:52, Andrei Lepikhov wrote:
> On 25/2/2024 20:32, Tender Wang wrote:
>> I think in prepare_probe_slot(), should called datumCopy as the
>> attached patch does.
>>
>> Any thoughts? Thanks.
> Thanks for the report.
> I think it is better to invent a Runtime Memory Context; likewise, it is
> already designed in IndexScan and derivatives. Here, you just allocate
> the value in some upper memory context.
> Also, I'm curious why such a trivial error hasn't been found for a long
> time
Hmmm. I see the problem (test.sql in attachment for reproduction and
results). We only detect it by the number of Hits:
Cache Key: t1.x, (t1.t)::numeric
Cache Mode: logical
Hits: 0 Misses: 30 Evictions: 0 Overflows: 0 Memory Usage: 8kB
We see no hits in logical mode and 100 hits in binary mode. We see 15
hits for both logical and binary mode if parameters are integer numbers
- no problems with resetting expression context.
Your patch resolves the issue for logical mode - I see 15 hits for
integer and complex keys. But I still see 100 hits in binary mode. Maybe
we still have a problem?
What's more, why the Memoize node doesn't see the problem at all?
--
regards,
Andrei Lepikhov
Postgres Professional
Attachments:
test.sql (application/sql, 7.5K) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: a.lepikhov@postgrespro.ru, tndrwang@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: "type with xxxx does not exist" when doing ExecMemoize()
In-Reply-To: <32a955a1-1cbb-442e-b903-bcb5982a1e58@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox