pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Richard Guo <guofenglinux@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: Clause accidentally pushed down ( Possible bug in Making Vars outer-join aware)
Date: Mon, 22 May 2023 11:07:23 +0500
Message-ID: <32adb59d-e1ea-9ccd-9aac-00677e53b44c@postgrespro.ru> (raw)
In-Reply-To: <288016.1684522205@sss.pgh.pa.us>
References: <0b819232-4b50-f245-1c7d-c8c61bf41827@postgrespro.ru>
	<402433.1677524538@sss.pgh.pa.us>
	<2663884e-769a-b298-55b0-014c5a1ee55c@postgrespro.ru>
	<524303.1677538463@sss.pgh.pa.us>
	<999171.1677611407@sss.pgh.pa.us>
	<CAMbWs4-Pi5cM=V8B-g5Qfnr0t3EgAbhus0YNQN=XquJ8fNoatw@mail.gmail.com>
	<CAMbWs4-Pmh9umsUbfs8Lay=k6wFrsuLdLJ7ci=Af6DqAwsN1Hg@mail.gmail.com>
	<CA+TgmoZ9yQLYziHAbt_X3hpU8FKkPXGLV=OhoD-GejAUckQbrA@mail.gmail.com>
	<CA+TgmoaeccFHN9ouXiSQmMJVh6uF-ANbbDjrwopQ+icYyzJSJw@mail.gmail.com>
	<CAMbWs4_nudsuzd-bLLgu1WCzeV1pLv3SG1Ub8vo-ETJzvgc0Bg@mail.gmail.com>
	<1526312.1683912310@sss.pgh.pa.us>
	<27! 66442.1684265014@sss.pgh.pa.us>
	<3014965.1684293045@sss.pgh.pa.us>
	<CAMbWs48iJprH69xQ27nigwODu1m_4U3Y2WMTxk47sTVdkW0Seg@mail.gmail.com>
	<3344781.1684337332@sss.pgh.pa.us>
	<CAMbWs4-EU9uBGSP7G-iTwLBhRQ=rnZKvFDhD+n+xhajokyPCKg@mail.gmail.com>
	<3732983.1684416513@sss.pgh.pa.us>
	<CAMbWs49xNW4xU=TQoYhhicvOyK6LLRm1GWr9xDDhCjuaqptWpw@mail.gmail.com>
	<288016.1684522205@sss.pgh.pa.us>

On 5/19/23 23:50, Tom Lane wrote:
> Richard Guo <guofenglinux@gmail.com> writes:
 >> ...
>> We'd be mistaken to think t1/t2 join is removable, because we are
>> checking its syntactic relid set, which includes all rels, and so that
>> are not aware that t2.a is used by t2/t3 join.
 > ...
> I think your patch is correct.

Because the feature pushed into the master, I checked it with the 
sqlancer tests. During all-weekend run no any problems were found.

-- 
Regards
Andrey Lepikhov
Postgres Professional






view thread (46+ messages)  latest in thread

Message-ID: <32adb59d-e1ea-9ccd-9aac-00677e53b44c@postgrespro.ru>
Permalink:  ../32adb59d-e1ea-9ccd-9aac-00677e53b44c@postgrespro.ru/
Also on:    postgresql.org/message-id/32adb59d-e1ea-9ccd-9aac-00677e53b44c@postgrespro.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: a.lepikhov@postgrespro.ru, tgl@sss.pgh.pa.us, guofenglinux@gmail.com, robertmhaas@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: Clause accidentally pushed down ( Possible bug in Making Vars outer-join aware)
  In-Reply-To: <32adb59d-e1ea-9ccd-9aac-00677e53b44c@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox