pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: maxim.boguk@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17871: JIT during postgresql_fdw remote_estimates EXPLAIN have very negatively effect on planning time
Date: Mon, 27 Mar 2023 23:20:30 -0400
Message-ID: <3386397.1679973630@sss.pgh.pa.us> (raw)
In-Reply-To: <CAApHDvqqJ+Q3p984U4Qu3DJ3PEZUAu=8-reH3-Ztv+sVoYkAhA@mail.gmail.com>
References: <17871-16521a70c16cb83c@postgresql.org>
	<20230327212830.dpp2u47je5ozf5q7@awork3.anarazel.de>
	<3348298.1679953099@sss.pgh.pa.us>
	<CAApHDvqqJ+Q3p984U4Qu3DJ3PEZUAu=8-reH3-Ztv+sVoYkAhA@mail.gmail.com>

David Rowley <dgrowleyml@gmail.com> writes:
> I guess that means just add a check for EXEC_FLAG_EXPLAIN_ONLY in
> jit_compile_expr, or only set the es_jit_flags bits in
> standard_ExecutorStart() when not in EXEC_FLAG_EXPLAIN_ONLY. I'm not
> really sure which of those is better, but the attached does the former
> and seems to fix the issue.

Hmm, offhand I'd vote for the latter, because it adds cycles only
once per query not once per expression.  But Andres may have a
better idea about how to do this.

			regards, tom lane





view thread (18+ messages)  latest in thread

Message-ID: <3386397.1679973630@sss.pgh.pa.us>
Permalink:  ../3386397.1679973630@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3386397.1679973630@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, dgrowleyml@gmail.com, andres@anarazel.de, maxim.boguk@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17871: JIT during postgresql_fdw remote_estimates EXPLAIN have very negatively effect on planning time
  In-Reply-To: <3386397.1679973630@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox