From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17076: Server crashes on composing an error message about invalid modulus for a new table partition
Date: Mon, 28 Jun 2021 18:30:32 -0400
Message-ID: <346711.1624919432@sss.pgh.pa.us> (raw)
In-Reply-To: <342122.1624914489@sss.pgh.pa.us>
References: <17076-89a16ae835d329b9@postgresql.org>
<342122.1624914489@sss.pgh.pa.us>
I wrote:
> I think the patch has got more problems than that too, as it's far
> from clear why the next remainder would have anything to do with the
> next larger modulus. IOW I suspect that when it does manage to print
> a partition name without crashing, it's very likely to print the
> wrong partition.
Concretely, this variant of the test case:
drop table hash_parted;
CREATE TABLE hash_parted (
a int
) PARTITION BY HASH (a);
CREATE TABLE hpart_1 PARTITION OF hash_parted FOR VALUES WITH (MODULUS 50, REMAINDER 0);
CREATE TABLE hpart_2 PARTITION OF hash_parted FOR VALUES WITH (MODULUS 10, REMAINDER 1);
CREATE TABLE hpart_3 PARTITION OF hash_parted FOR VALUES WITH (MODULUS 200, REMAINDER 2);
CREATE TABLE fail_part PARTITION OF hash_parted FOR VALUES WITH (MODULUS 25, REMAINDER 3);
prints
ERROR: every hash partition modulus must be a factor of the next larger modulus
DETAIL: The new modulus 25 is not divisible by 10, the modulus of existing partition "hpart_1".
which is obviously wrong.
I think that rescuing this might require scanning through the list of
partitions for one that has the desired modulus. There could be more
than one match, but I'd be content to take the first one.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17076: Server crashes on composing an error message about invalid modulus for a new table partition
In-Reply-To: <346711.1624919432@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox