pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Japin Li <japinli@hotmail.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Richard Guo <guofenglinux@gmail.com>
Cc: a.kozhemyakin@postgrespro.ru
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17570: Unrecognized node type for query with statistics on expressions
Date: Thu, 04 Aug 2022 11:42:38 -0400
Message-ID: <3508845.1659627758@sss.pgh.pa.us> (raw)
In-Reply-To: <ME3P282MB1667E822B3DEA81E46EEE11CB69F9@ME3P282MB1667.AUSP282.PROD.OUTLOOK.COM>
References: <17570-f2f2e0f4bccf0965@postgresql.org>
	<CAMbWs4_PPrJ7JFXqewQfkMLP6-2kHi+5=11U0csQVTx7iq7esw@mail.gmail.com>
	<CAMbWs49MoDfQzbcmH4VWisTNVDfCuZcALPOzJxGac2UV5KVi7w@mail.gmail.com>
	<ME3P282MB1667E822B3DEA81E46EEE11CB69F9@ME3P282MB1667.AUSP282.PROD.OUTLOOK.COM>

Japin Li <japinli@hotmail.com> writes:
> Attached to new patch add a test-case from Alexander Kozhemyakin.

It appears to me that this is actually very thoroughly broken.

* statext_is_compatible_clause_internal is not on board with
offsetting the attnums.

* Neither is this check for a whole-row reference (line 1628, in HEAD):

		if (bms_is_member(InvalidAttrNumber, clause_attnums))

* Although the coverage report claims this code is exercised, the
fact that nothing failed when you made only a partial fix says it's
not exercised well enough.

* The comments for statext_is_compatible_clause suck.  If they'd
defined what the arguments are, perhaps this mess would have been
prevented.  For extra credit, it'd be really nice to define what
"is compatible" means.  I'd sure not have thought that that would
include permissions checks.

			regards, tom lane





view thread (10+ messages)  latest in thread

Message-ID: <3508845.1659627758@sss.pgh.pa.us>
Permalink:  ../3508845.1659627758@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3508845.1659627758@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, japinli@hotmail.com, tomas.vondra@enterprisedb.com, guofenglinux@gmail.com, a.kozhemyakin@postgrespro.ru, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17570: Unrecognized node type for query with statistics on expressions
  In-Reply-To: <3508845.1659627758@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox