pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Tender Wang <tndrwang@gmail.com>
Cc: nicolas.maus@bertelsmann.de
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18692: Segmentation fault when extending a varchar column with a gist index with custom signal length
Date: Fri, 08 Nov 2024 09:49:10 -0500
Message-ID: <3629173.1731077350@sss.pgh.pa.us> (raw)
In-Reply-To: <CAPpHfdsH6ACTzcBAs_YC+UzFgjCWTzhNpaAOxssEJ75jH5xVXw@mail.gmail.com>
References: <18692-72ea398df3ec6712@postgresql.org>
	<3261639.1730912933@sss.pgh.pa.us>
	<CAPpHfdsedeW4qiF_Ky88u=+0Ep7ZGH5yBd47a-rueQ2_jh3Dhw@mail.gmail.com>
	<CAHewXN=eBAk2wMn00CCYqcqC-1UtCHBMxr0nREUp_Ch8XYSQEg@mail.gmail.com>
	<CAPpHfdvc1C4Q9LQ-x9SarnM14UcaqxvursrZWrQbF8r2CT9ghg@mail.gmail.com>
	<3534898.1731031548@sss.pgh.pa.us>
	<CAPpHfdtZ2a=1FbZXUeEbx0i-avsQb=6UE9Kg8eTLoQzt3KaY0w@mail.gmail.com>
	<3557257.1731042654@sss.pgh.pa.us>
	<CAPpHfdsH6ACTzcBAs_YC+UzFgjCWTzhNpaAOxssEJ75jH5xVXw@mail.gmail.com>

Alexander Korotkov <aekorotkov@gmail.com> writes:
> On Fri, Nov 8, 2024 at 7:10 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> WFM.  But I'm concerned that you couldn't build a test case
>> where the comparison fails.  Seems like we need one, in view
>> of this bug having escaped detection for so long.

> AFAICS, the only use case of CheckIndexCompatible() is ALTER TYPE.  In
> that case we only serialize and deserialize opclass options without
> any involvement of opclass or data type.  So, with the current usage
> scenario CompareOpclassOptions() is only a paranoid check, but
> CheckIndexCompatible() has to do it due to its general semantic.

OK.  Well, let's settle for having a test case that at least runs
the code, even if only the success path is taken.

With the release freeze bearing down on us, do you want to wait
till after the releases to fix this?  It seems non-urgent given
how long it took for anyone to notice.

			regards, tom lane





view thread (13+ messages)  latest in thread

Message-ID: <3629173.1731077350@sss.pgh.pa.us>
Permalink:  ../3629173.1731077350@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3629173.1731077350@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, aekorotkov@gmail.com, tndrwang@gmail.com, nicolas.maus@bertelsmann.de, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #18692: Segmentation fault when extending a varchar column with a gist index with custom signal length
  In-Reply-To: <3629173.1731077350@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox