From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: okano.naoki@jp.fujitsu.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages doesn't work.
Date: Fri, 16 Sep 2022 10:29:38 -0400
Message-ID: <3677878.1663338578@sss.pgh.pa.us> (raw)
In-Reply-To: <YyRxXJ+FXOWTBBrb@paquier.xyz>
References: <17448-0a96583a67edb1f7@postgresql.org>
<Yj6oxYsBE5LXA8ZP@paquier.xyz>
<20220326082408.moh55zuecxjmewnm@jrouhaud>
<CA+hUKGLwOSf-QwVtCcKx9xvugN2BSzEBBeD5DNyTXgcSRp5sTw@mail.gmail.com>
<YyRxXJ+FXOWTBBrb@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> So based on that I think that we could just apply and backpatch what
> you have here. This issue is much easier to reason about on HEAD
> where we just care about Win >= 10, and we've be rather careful with
> changes like that when it came to Windows. Any objections about doing
> a backpatch? I'd like to do so after an extra lookup, if there are no
> objections. Or would folks prefer a HEAD-only fix for now?
Let's just fix it in HEAD. I think the risk/reward ratio isn't very
good here.
(I'd be particularly against changing this in v10, because 10.23 will
be the last one; there will be no second chance if we ship it broken.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, thomas.munro@gmail.com, rjuju123@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages doesn't work.
In-Reply-To: <3677878.1663338578@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox