From: Tom Lane <tgl@sss.pgh.pa.us>
To: david@swarm64.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16673: Stack depth limit exceeded error while running sysbench TPC-C
Date: Thu, 15 Oct 2020 10:09:31 -0400
Message-ID: <3679451.1602770971@sss.pgh.pa.us> (raw)
In-Reply-To: <16673-d278c604f8e34ec0@postgresql.org>
References: <16673-d278c604f8e34ec0@postgresql.org>
PG Bug reporting form <noreply@postgresql.org> writes:
> [ signal recursion in postmaster ]
This looks like the same issue that we fixed in HEAD/v13 just about
a year ago:
Author: Tom Lane <tgl@sss.pgh.pa.us>
Branch: master Release: REL_13_BR [9abb2bfc0] 2019-10-13 15:48:26 -0400
In the postmaster, rely on the signal infrastructure to block signals.
POSIX sigaction(2) can be told to block a set of signals while a
signal handler executes. Make use of that instead of manually
blocking and unblocking signals in the postmaster's signal handlers.
This should save a few cycles, and it also prevents recursive
invocation of signal handlers when many signals arrive in close
succession. We have seen buildfarm failures that seem to be due to
postmaster stack overflow caused by such recursion (exacerbated by
a Linux PPC64 kernel bug).
This doesn't change anything about the way that it works on Windows.
Somebody might consider adjusting port/win32/signal.c to let it work
similarly, but I'm not in a position to do that.
For the moment, just apply to HEAD. Possibly we should consider
back-patching this, but it'd be good to let it age awhile first.
Discussion: https://postgr.es/m/14878.1570820201@sss.pgh.pa.us
Maybe now it's aged enough to back-patch?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, david@swarm64.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16673: Stack depth limit exceeded error while running sysbench TPC-C
In-Reply-To: <3679451.1602770971@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox