pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: ben@lantern.is
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16112: large, unexpected memory consumption
Date: Wed, 13 Nov 2019 12:21:47 -0500
Message-ID: <368.1573665707@sss.pgh.pa.us> (raw)
In-Reply-To: <20191113170528.caywphoaq45ggqbx@alap3.anarazel.de>
References: <16112-4448bbf55a404189@postgresql.org>
	<20191113145004.opxx4vuajyoadbcq@development>
	<20191113170528.caywphoaq45ggqbx@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2019-11-13 15:50:04 +0100, Tomas Vondra wrote:
>> The attached trivial patch fixes that by adding a pfree() at the end of
>> the function.

> Hm. That's clearly an improvement. But I'm not quite sure it's really
> the right direction. It seems like a bad idea to rely on
> ExecMakeTableFunctionResult() otherwise never leaking any memory.

Considering that ExecMakeTableFunctionResult went from zero pallocs
to one, I don't see a strong reason why it should have bothered with
a private memory context before, nor do I think that's a good
response now.

			regards, tom lane





view thread (16+ messages)  latest in thread

Message-ID: <368.1573665707@sss.pgh.pa.us>
Permalink:  ../368.1573665707@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/368.1573665707@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, tomas.vondra@2ndquadrant.com, ben@lantern.is, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16112: large, unexpected memory consumption
  In-Reply-To: <368.1573665707@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox