From: Tom Lane <tgl@sss.pgh.pa.us>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: adam.warland@infor.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19341: REPLACE() fails to match final character when using nondeterministic ICU collation
Date: Tue, 02 Dec 2025 12:25:52 -0500
Message-ID: <375807.1764696352@sss.pgh.pa.us> (raw)
In-Reply-To: <9f47c6b24d6cf59002603caf19b8b3f4854176be.camel@cybertec.at>
References: <19341-1d9a22915edfec58@postgresql.org>
<60b467ac47d5c6bbb9c21c3bdfecce8e5de60cda.camel@cybertec.at>
<6935ea1e-cfb1-400b-9057-3d43b55d621a@iki.fi>
<9f47c6b24d6cf59002603caf19b8b3f4854176be.camel@cybertec.at>
Laurenz Albe <laurenz.albe@cybertec.at> writes:
>>> for (const char *test_end = hptr; test_end <= haystack_end; test_end += pg_mblen(test_end))
> During the last iteration of the loop, "test_end" will be equal to "haystack_end",
> and the loop increment will call "pg_mblen(test_end)".
Right, clearly unsafe (and I bet valgrind would complain about it).
You need to rearrange the loop logic so that we won't attempt to
increment test_end that last time through. Perhaps a for-loop
isn't the best way to write it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, laurenz.albe@cybertec.at, hlinnaka@iki.fi, adam.warland@infor.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19341: REPLACE() fails to match final character when using nondeterministic ICU collation
In-Reply-To: <375807.1764696352@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox