From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Jeff Davis <pgsql@j-davis.com>
To: Kyle Spearrin <kspearrin@bitwarden.com>
To: pgsql-bugs@lists.postgresql.org
Cc: Justin Baur <jbaur@bitwarden.com>
Cc: Vince Grassia <vgrassia@bitwarden.com>
Subject: Re: CREATE COLLATION without LOCALE throws error in v15
Date: Thu, 8 Dec 2022 19:29:31 +0100
Message-ID: <38ab220b-83a7-17a4-42b1-923a5f96ef15@enterprisedb.com> (raw)
In-Reply-To: <69598b5a07183ea8c6ec20826c1b549db1128070.camel@j-davis.com>
References: <CALDQics_oBEYfOnu_zH6yw9WR1waPCmcrqxQ8+39hK3Op=z2UQ@mail.gmail.com>
<7b99b4a7fc5284008bae32b77a776d25b4a400bc.camel@j-davis.com>
<428169fe-2eb3-4415-a5be-6f59112f26b2@enterprisedb.com>
<69598b5a07183ea8c6ec20826c1b549db1128070.camel@j-davis.com>
On 07.12.22 18:44, Jeff Davis wrote:
> On Wed, 2022-12-07 at 13:04 +0100, Peter Eisentraut wrote:
>> This was an intentional change because of underlying conceptual and
>> catalog changes. lc_collate, lc_ctype, and iculocale are now tracked
>> separately in the catalogs. This is also important because for a
>> database they actually are used separately. So this also keeps the
>> locale/collation settings for databases and collations consistent.
>
> That makes sense, but there also doesn't seem to be much harm in
> supporting the old behavior where it works as long as ctype==collate.
> As in my patch, it accepts either locale or ctype==collate as the icu
> locale.
The harm is that in the context of database-level collations, the
analogous syntax means something different. That's why in the context
of adding ICU support on the database level, this syntax for collation
objects was disabled.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, pgsql@j-davis.com, kspearrin@bitwarden.com, pgsql-bugs@lists.postgresql.org, jbaur@bitwarden.com, vgrassia@bitwarden.com
Subject: Re: CREATE COLLATION without LOCALE throws error in v15
In-Reply-To: <38ab220b-83a7-17a4-42b1-923a5f96ef15@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox