pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Vik Fearing <vik@postgresfriends.org>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Arthur Nascimento <tureba@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16867: savepoints vs. commit and chain
Date: Thu, 18 Feb 2021 15:10:32 +0100
Message-ID: <38fcac1f-e4b8-40ff-41ff-819b5ab8b9b7@postgresfriends.org> (raw)
In-Reply-To: <e3fbc15b-9aef-b076-d72e-20b537186342@oss.nttdata.com>
References: <16867-3475744069228158@postgresql.org>
	<CALVFHFaBUXnCxv2kfG67=3NR=WPkVGgE_5Cf9S-LDPNYAwUORQ@mail.gmail.com>
	<473dba6b-dfb3-b5a8-93c6-af3787893728@oss.nttdata.com>
	<CALVFHFanjZ_K=xVbHE31QiAHcLfQU8g1Z-UYMHoPw1q-kAnDyA@mail.gmail.com>
	<e3fbc15b-9aef-b076-d72e-20b537186342@oss.nttdata.com>

On 2/18/21 2:58 PM, Fujii Masao wrote:
> 
> 
> On 2021/02/17 3:03, Arthur Nascimento wrote:
>> Hi, Fujii-san,
>>
>> On Tue, 16 Feb 2021 at 01:49, Fujii Masao
>> <masao.fujii@oss.nttdata.com> wrote:
>>> In the server side, ISTM that CommitTransactionCommand() needs to handle
>>> the COMMIT AND CHAIN in TBLOCK_SUBCOMMIT case, but it forgot to do that.
>>> Patch attached. I'm not sure if this is a bug or an intentional
>>> behavior.
>>> Probably we need to look at the past discussion about AND CHAIN feature.
>>
>> I can confirm that your patch solved it for me. Thanks for looking
>> into it.
> 
> Thanks for testing the patch!
> 
> As far as I read the past discussion about chain transaction,
> I could not find any mention that current behavior that you reported
> is intentional.
> 
> Barring any objection, I will commit the patch that you wrote
> for psql and the patch I wrote.

No objection from me.  According to the standard, a COMMIT should
destroy all savepoints and terminate the transaction, even if AND CHAIN
is specified.
-- 
Vik Fearing





view thread (9+ messages)  latest in thread

Message-ID: <38fcac1f-e4b8-40ff-41ff-819b5ab8b9b7@postgresfriends.org>
Permalink:  ../38fcac1f-e4b8-40ff-41ff-819b5ab8b9b7@postgresfriends.org/
Also on:    postgresql.org/message-id/38fcac1f-e4b8-40ff-41ff-819b5ab8b9b7@postgresfriends.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: vik@postgresfriends.org, masao.fujii@oss.nttdata.com, tureba@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16867: savepoints vs. commit and chain
  In-Reply-To: <38fcac1f-e4b8-40ff-41ff-819b5ab8b9b7@postgresfriends.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox